[2.6 patch] SCSI_QLA2ABC mustn't select SCSI_FC_ATTRS

[Adrian Bunk <bunk@stusta.de>]

[ The subject was adapted to linux-kernel spam filters... ]

On Fri, Jul 15, 2005 at 07:40:37AM -0700, Andrew Vasquez wrote:
> On Fri, 15 Jul 2005, Adrian Bunk wrote:
> 
> > On Fri, Jul 15, 2005 at 01:36:53AM -0700, Andrew Morton wrote:
> > >...
> > > Changes since 2.6.13-rc2-mm2:
> > >...
> > >  git-scsi-misc.patch
> > >...
> > >  Subsystem trees
> > >...
> > 
> ...
> > +obj-$(CONFIG_SCSI_QLA24XX) += qla2xxx.o
> > 
> > 
> > I don't know what exactly you want to achieve, but this is so horribly 
> > wrong.
> 
> 
> Yes, quite.  How about the following to correct the intention.
>...

It looks good (except that you used spaces instead of a tab in the 
"select" line, but that's only a minor nitpick).

Below is another fix for a different issue that was already present.

cu
Adrian


<--  snip  -->


SCSI_QLA2XXX is automatically enabled for (SCSI && PCI).
It therefore mustn't select SCSI_FC_ATTRS, since it otherwise 
unconditionally enables SCSI_FC_ATTRS for all users with
(SCSI && PCI) enabled, even when they don't need any support for
QLogic hardware.

This patch also does a cosmetic change for making the "default" look 
more like in other kernel code.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.13-rc3-mm1-full/drivers/scsi/qla2xxx/Kconfig.old	2005-07-15 22:05:19.000000000 +0200
+++ linux-2.6.13-rc3-mm1-full/drivers/scsi/qla2xxx/Kconfig	2005-07-15 22:07:42.000000000 +0200
@@ -1,8 +1,7 @@
 config SCSI_QLA2XXX
 	tristate
-	default (SCSI && PCI)
 	depends on SCSI && PCI
-	select SCSI_FC_ATTRS
+	default y
 
 config SCSI_QLA21XX
 	tristate "QLogic ISP2100 host adapter family support"

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/