It looks like a couple of exports and a key supporting function are
missing from the inotify patch that went into mainline yesterday.
I don't see an inode operation for registering inotify events in the fs
(there is a file operation for dir_notify to register its events). In
create_watch in fs/inotify.c I expected to see something like:
if(inode->inotify_create)
ret = inode->inotify_create(inode, mask);
(a similar change would be needed in the INOTIFY_IGNORE path)
Without this, inotify will be broken except on local filesystems.
Cluster and network filesystems (nfs, cifs etc.) won't know when they
need to start calling back on remote directory change notifications if
they aren't called at the time of the ioctl(INOTIFY_WATCH)
I also don't see exports for
fsnotify_access
fsnotify_modify
Without these exports, network and cluster filesystems can't notify the
local system about changes.
Tracking local changes to files/directories is somewhat useful by itself
on non-networked systems. But if directory and file change notification
for remote/cluster filesystems is broken that limits its usefullness a
lot.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |