Matthew Garrett wrote: > Micheal Marineau <[email protected]> wrote: > > >>+ if (pdev->dev.power.power_state != 4) >>+ { >>+ pci_restore_state (pdev); >>+ acpi_vgapost (pdev->devfn); >>+ } > > > Please *don't* make this unconditional. There's no guarantee that the > video BIOS is postable after initial system boot. A boot-time parameter > to enable it seems reasonable, but in general we're likely to stand a > much better chance getting it working in userspace. A kernel parameter seems reasonable, I assume that pci_restore_state shoule remain unconditional right? Userspace works just fine if the frame buffer is not used, but it has to be done in kernel when using a frame buffer. -- Michael Marineau [email protected] Oregon State University
Attachment:
signature.asc
Description: OpenPGP digital signature
- References:
- [PATCH][help?] Radeonfb acpi resume
- From: Micheal Marineau <[email protected]>
- [PATCH][help?] Radeonfb acpi resume
- Prev by Date: Re: [SOLVED] Re: 2.6.13-rc2 hangs at boot
- Next by Date: Re: 2.6.12.2 dies after 24 hours
- Previous by thread: Re: [PATCH][help?] Radeonfb acpi resume
- Next by thread: Re: [PATCH][help?] Radeonfb acpi resume
- Index(es):
