Re: [PATCH] tpm: Support for new chip type

[Pavel Machek <pavel@ucw.cz>]

Hi!

> after some corrections here is a newer patch supporting the Infineon Trusted Platform
> Module SLD 9630 (TPM 1.1b), which is embedded on Intel-mainboards or in
> HP/Fujitsu-Siemens/Toshiba-Notebooks.
> The module fits the interfaces created by IBM and was patched against the
> latest kernel-snapshot 2.6.13-rc2.
> Further information about this module and a list of supported hardware can be
> found here: http://www.prosec.rub.de/tpm
> 
> Best Regards,
> Marcel Selhorst
> 
> Signed-off-by: Marcel Selhorst <selhorst@crypto.rub.de>

> diff -uprN linux-2.6.12.2/drivers/char/tpm/tpm_infineon.c linux/drivers/char/tpm/tpm_infineon.c
> --- linux-2.6.12.2/drivers/char/tpm/tpm_infineon.c	1970-01-01 00:00:00.000000000 +0000
> +++ linux/drivers/char/tpm/tpm_infineon.c	2005-07-07 14:56:27.000000000 +0000
> @@ -0,0 +1,505 @@
> +/*
> + * Copyright (C) 2005
> + * Marcel Selhorst <selhorst@crypto.rub.de>
> + * Applied Data Security Group
> + * Ruhr-University Bochum, Germany
> + *

Could you make this

> + * Copyright (C) 2005 Marcel Selhorst <selhorst@crypto.rub.de>
> + * Applied Data Security Group Ruhr-University Bochum, Germany

and make sure Description stands out a bit more (like maybe putting it
first?)

> + * Description:
> + * Device Driver for the Infineon Technologies
> + * SLD 9630 TT Trusted Platform Module
> + * Specifications at www.trustedcomputinggroup.org	
> + *
> + * Project-Homepage:
> + * http://www.prosec.rub.de/tpm
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation, version 2 of the
> + * License.
> + *
> + */

> +#include "tpm.h"
> +
> +/* Infineon specific delay definitions */
> +enum infineon_tpm_delay {
> +	TPM_MAX_WTX_PACKAGES = 50,	/* maximum number of WTX-packages */
> +	TPM_WTX_MSLEEP_TIME = 20,	/* msleep-Time for WTX-packages */
> +	TPM_MSLEEP_TIME = 3,	/* msleep-Time --> Interval to check status register */
> +	TPM_MAX_TRIES = 5000	/* gives number of max. msleep()-calls before
> +				   throwing timeout */
> +};

> +/* Infineon specific TPM data */
> +enum infineon_tpm_specific {
> +	TCPA_INFINEON_DEV_VEN_VALUE = 0x15D1,
> +	TPM_DATA = (TPM_ADDR + 1) & 0xff
> +};

Ugh, is it just me or are you abusing enums a bit?
> +static int __init tpm_inf_probe(struct pci_dev *pci_dev,
> +				const struct pci_device_id *pci_id)
> +{
> +
> +	int rc = 0;
> +	u8 ioh;
> +	u8 iol;

Put these two on one line? Are you sure probe can't be called during
runtime for some pci hotplug case?
								Pavel
-- 
teflon -- maybe it is a trademark, but it should not be.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/