On Thu, Jul 07, 2005 at 09:30:21PM +0200, Stefan Richter wrote:
> Jody McIntyre wrote:
> >On Mon, Jul 04, 2005 at 01:24:05AM +0200, Adrian Bunk wrote:
> >>What shall I do?
> >>- resend this patch with the removal date set to August or
> >
> >That should be fine. I'll watch for it this time. August isn't much
> >time though; isn't the "standard" 6 months to a year?
>
> August is fine; it's our sloppiness that the remove announcement did not
> go in earlier. People who run external projects that use such symbols
> might have had forewarning by the previous discussion rounds on
> linux1394-devel.
Updated patch below.
> >>+What: remove the following ieee1394 EXPORT_SYMBOL's:
> >>+ - hpsb_send_phy_config
> >>+ - hpsb_send_packet_and_wait
> >>+ - highlevel_add_host
> >>+ - highlevel_remove_host
> >>+ - nodemgr_for_each_host
> >>+ - csr1212_create_csr
> >>+ - csr1212_init_local_csr
> >>+ - csr1212_new_immediate
> >>+ - csr1212_associate_keyval
> >>+ - csr1212_new_string_descriptor_leaf
> >>+ - csr1212_destroy_csr
> >>+ - csr1212_generate_csr_image
> >>+ - csr1212_parse_csr
>
> Now that we are at it, the following EXPORT_SYMBOLs should be removed too...
> _csr1212_read_keyval
used in sbp2.c
> _csr1212_destroy_keyval
used in raw1394.c
>...
> Stefan Richter
cu
Adrian
<-- snip -->
This patch schedules unused EXPORT_SYMBOL's for removal.
Signed-off-by: Adrian Bunk <[email protected]>
---
Documentation/feature-removal-schedule.txt | 21 ++++++++++++++
drivers/ieee1394/ieee1394_core.c | 31 +++++++++++++++++++++
2 files changed, 52 insertions(+)
--- linux-2.6.12-rc4-mm1-full/Documentation/feature-removal-schedule.txt.old 2005-05-13 15:19:54.000000000 +0200
+++ linux-2.6.12-rc4-mm1-full/Documentation/feature-removal-schedule.txt 2005-05-13 15:29:24.000000000 +0200
@@ -93,0 +94,21 @@
+
+---------------------------
+
+What: remove the following ieee1394 EXPORT_SYMBOL's:
+ - hpsb_send_phy_config
+ - hpsb_send_packet_and_wait
+ - highlevel_add_host
+ - highlevel_remove_host
+ - nodemgr_for_each_host
+ - csr1212_create_csr
+ - csr1212_init_local_csr
+ - csr1212_new_immediate
+ - csr1212_associate_keyval
+ - csr1212_new_string_descriptor_leaf
+ - csr1212_destroy_csr
+ - csr1212_generate_csr_image
+ - csr1212_parse_csr
+When: August 2005
+Files: drivers/ieee1394/ieee1394_core.c
+Why: No modular usage in the kernel.
+Who: Adrian Bunk <[email protected]>
--- linux-2.6.12-rc4-mm1-full/drivers/ieee1394/ieee1394_core.c.old 2005-05-13 15:19:34.000000000 +0200
+++ linux-2.6.12-rc4-mm1-full/drivers/ieee1394/ieee1394_core.c 2005-05-13 15:28:17.000000000 +0200
@@ -1226,7 +1226,13 @@
EXPORT_SYMBOL(hpsb_alloc_packet);
EXPORT_SYMBOL(hpsb_free_packet);
+
+/* EXPORT_SYMBOL scheduled for removal */
EXPORT_SYMBOL(hpsb_send_phy_config);
+
EXPORT_SYMBOL(hpsb_send_packet);
+
+/* EXPORT_SYMBOL scheduled for removal */
EXPORT_SYMBOL(hpsb_send_packet_and_wait);
+
EXPORT_SYMBOL(hpsb_reset_bus);
EXPORT_SYMBOL(hpsb_bus_reset);
@@ -1265,6 +1271,11 @@
EXPORT_SYMBOL(hpsb_get_hostinfo_bykey);
EXPORT_SYMBOL(hpsb_set_hostinfo);
+
+/* EXPORT_SYMBOL scheduled for removal */
EXPORT_SYMBOL(highlevel_add_host);
+
+/* EXPORT_SYMBOL scheduled for removal */
EXPORT_SYMBOL(highlevel_remove_host);
+
EXPORT_SYMBOL(highlevel_host_reset);
@@ -1275,4 +1286,6 @@
EXPORT_SYMBOL(hpsb_unregister_protocol);
EXPORT_SYMBOL(ieee1394_bus_type);
+
+/* EXPORT_SYMBOL scheduled for removal */
EXPORT_SYMBOL(nodemgr_for_each_host);
@@ -1312,18 +1325,36 @@
/** csr1212.c **/
+
+/* EXPORT_SYMBOLs scheduled for removal */
EXPORT_SYMBOL(csr1212_create_csr);
EXPORT_SYMBOL(csr1212_init_local_csr);
EXPORT_SYMBOL(csr1212_new_immediate);
+
EXPORT_SYMBOL(csr1212_new_directory);
+
+/* EXPORT_SYMBOL scheduled for removal */
EXPORT_SYMBOL(csr1212_associate_keyval);
+
EXPORT_SYMBOL(csr1212_attach_keyval_to_directory);
+
+/* EXPORT_SYMBOL scheduled for removal */
EXPORT_SYMBOL(csr1212_new_string_descriptor_leaf);
+
EXPORT_SYMBOL(csr1212_detach_keyval_from_directory);
EXPORT_SYMBOL(csr1212_release_keyval);
+
+/* EXPORT_SYMBOL scheduled for removal */
EXPORT_SYMBOL(csr1212_destroy_csr);
+
EXPORT_SYMBOL(csr1212_read);
+
+/* EXPORT_SYMBOL scheduled for removal */
EXPORT_SYMBOL(csr1212_generate_csr_image);
+
EXPORT_SYMBOL(csr1212_parse_keyval);
+
+/* EXPORT_SYMBOL scheduled for removal */
EXPORT_SYMBOL(csr1212_parse_csr);
+
EXPORT_SYMBOL(_csr1212_read_keyval);
EXPORT_SYMBOL(_csr1212_destroy_keyval);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |