On Thu, Jul 07, 2005 at 09:38:17AM -0700, Linus Torvalds wrote:
>
>
> On Thu, 7 Jul 2005, Christoph Lameter wrote:
> >
> > Here is IMHO the right way to fix this. Test for the hwif != NULL and
> > test for pci_dev != NULL before determining the node number of the pci
> > bus that the device is connected to.
>
> I think this is pretty unreadable.
>
> If you make it use a trivial inline function for the thing, I think that
> would be ok, though.
>
> Complex expressions are bad.
You could just use the previous patch I posted (hint hint...;)
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |