Re: Patch of a new driver for kernel 2.4.x that need review

Pekka J Enberg <[email protected]> wrote:
> Mark Gross writes:
> 
> > +
> > +/* 0 = Dynamic allocation of the major device number */
> > +#define TLCLK_MAJOR 252
> 
> Enums, please. 
> 

But not here - it is a single constant, not a value of a distinct type.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: Patch of a new driver for kernel 2.4.x that need review
    • From: "Pekka J Enberg" <[email protected]>

• References:
  • Re: Patch of a new driver for kernel 2.4.x that need review
    • From: "Pekka J Enberg" <[email protected]>

• Prev by Date: Re: [PATCH] audit: file system auditing based on location and name
• Next by Date: Re: Patch of a new driver for kernel 2.4.x that need review
• Previous by thread: Re: Patch of a new driver for kernel 2.4.x that need review
• Next by thread: Re: Patch of a new driver for kernel 2.4.x that need review
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]