Re: [PATCH] Fix crash on boot in kmalloc_node IDE changes

On 7/6/05, Andi Kleen <[email protected]> wrote:
> > drive->hwif check is redundant, please remove it
> 
> It's not. My first version didn't have it but it still crashed.
> It's what actually prevents the crash.
> I also don't know why, but it's true.

very weird as HWIF(drive) == drive->hwif:

	ide_hwif_t *hwif = HWIF(drive);

...

	q = blk_init_queue_node(do_ide_request, &ide_lock,
				pcibus_to_node(drive->hwif->pci_dev->bus));
	if (!q)
		return 1;

...

	if (!hwif->rqsize) {

you should OOPS here

Bartlomiej
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Fix crash on boot in kmalloc_node IDE changes
    • From: Andi Kleen <[email protected]>

• References:
  • [PATCH] Fix crash on boot in kmalloc_node IDE changes
    • From: Andi Kleen <[email protected]>
  • Re: [PATCH] Fix crash on boot in kmalloc_node IDE changes
    • From: Bartlomiej Zolnierkiewicz <[email protected]>
  • Re: [PATCH] Fix crash on boot in kmalloc_node IDE changes
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: PROBLEM: please remove reserved word "new" from kernel headers
• Next by Date: Re: "Spy'ing" characters sent thru serial port ?
• Previous by thread: Re: [PATCH] Fix crash on boot in kmalloc_node IDE changes
• Next by thread: Re: [PATCH] Fix crash on boot in kmalloc_node IDE changes
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]