Re: [PATCH] Fix crash on boot in kmalloc_node IDE changes

On Wed, 6 Jul 2005, Andi Kleen wrote:

> -	q = blk_init_queue_node(do_ide_request, &ide_lock,
> -				pcibus_to_node(drive->hwif->pci_dev->bus));
> +	int node = 0; /* Should be -1 */

Why is this not -1?

> +		int node = 0; 
> +		if (hwif->drives[0].hwif) { 

Also needs to be -1.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Fix crash on boot in kmalloc_node IDE changes
    • From: Andi Kleen <[email protected]>

• References:
  • [PATCH] Fix crash on boot in kmalloc_node IDE changes
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: [PATCH] Run PCI driver initialization on local node
• Next by Date: Re: speedstep-centrino on dothan
• Previous by thread: Re: [PATCH] Fix crash on boot in kmalloc_node IDE changes
• Next by thread: Re: [PATCH] Fix crash on boot in kmalloc_node IDE changes
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]