Re: [2.6 patch] fix IP_FIB_HASH kconfig warning

[Roman Zippel <zippel@linux-m68k.org>]

Hi,

On Mon, 4 Jul 2005, Adrian Bunk wrote:

> --- linux-2.6.13-rc1-mm1-full/net/ipv4/Kconfig.old	2005-07-02 20:07:25.000000000 +0200
> +++ linux-2.6.13-rc1-mm1-full/net/ipv4/Kconfig	2005-07-02 20:13:05.000000000 +0200
> @@ -58,8 +58,9 @@
>  	depends on IP_ADVANCED_ROUTER
>  	default IP_FIB_HASH
>  
> -config IP_FIB_HASH
> +config ASK_IP_FIB_HASH
>  	bool "FIB_HASH"
> +	select IP_FIB_HASH
>  	---help---
>  	Current FIB is very proven and good enough for most users.
>  
> @@ -84,12 +85,9 @@
>         
>  endchoice
>  
> -# If the user does not enable advanced routing, he gets the safe
> -# default of the fib-hash algorithm.
>  config IP_FIB_HASH
>  	bool
> -	depends on !IP_ADVANCED_ROUTER
> -	default y
> +	default y if !IP_ADVANCED_ROUTER
>  
>  config IP_MULTIPLE_TABLES
>  	bool "IP: policy routing"

I'd prefer to do it without select.

config IP_FIB_HASH  
	def_bool ASK_IP_FIB_HASH || !IP_ADVANCED_ROUTER

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/