Re: [PATCH] ALPS: fix enabling hardware tapping

[Vojtech Pavlik <vojtech@suse.cz>]

On Mon, Jul 04, 2005 at 01:28:06AM +0200, Peter Osterlund wrote:

> Vojtech Pavlik <vojtech@suse.cz> writes:
> 
> > On Sun, Jul 03, 2005 at 01:49:13PM +0200, Peter Osterlund wrote:
> > > Dmitry Torokhov <dtor_core@ameritech.net> writes:
> > > 
> > > > It looks like logic for enabling hardware tapping in ALPS driver was
> > > > inverted and we enable it only if it was already enabled by BIOS or
> > > > firmware.
> > > 
> > > It looks like alps_init() has the same bug.  This patch fixes that
> > > function too by moving the check if the tapping mode needs to change
> > > into the alps_tap_mode() function, so that the test doesn't have to be
> > > duplicated.
> > 
> > This looks good. However - what's the point in checking whether tapping
> > is enabled before enabling it?
> 
> I don't think there is a point. IFAIK this code was added by Dmitry as
> part of the hardware auto-detection changes. In that version the check
> prevented a printk line when the touchpad was already in the correct
> state. That printk is deleted anyway by this patch, so the check can
> be removed. (Modulo weird hardware behavior, which can't be completely
> ruled out because the driver is based largely on reverse engineering,
> since no public docs are available.)
> 
> Signed-off-by: Peter Osterlund <petero2@telia.com>

Thanks; patch applied.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/