Re: [patch] swsusp: fix error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pavel Machek wrote:

> --- a/kernel/power/swsusp.c
> +++ b/kernel/power/swsusp.c

> @@ -998,14 +991,20 @@ int swsusp_suspend(void)
>  	 * at resume time, and evil weirdness ensues.
>  	 */
>  	if ((error = device_power_down(PMSG_FREEZE))) {
> -		printk(KERN_ERR "Some devices failed to power down, aborting suspend\n");

i don't like this one. Silent failures are a major PITA.

> +		printk("Error %d suspending\n", error);

therefor i like this one ;-) Maybe with a printk level?
-- 
Stefan Seyfried                  \ "I didn't want to write for pay. I
QA / R&D Team Mobile Devices      \ wanted to be paid for what I write."
SUSE LINUX Products GmbH, Nürnberg \                    -- Leonard Cohen

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]
  Powered by Linux