On Fri, Jul 01 2005, [email protected] wrote:
> --- linux-2.6.12/drivers/ide/ide-floppy.c.ORIG 2005-06-17
> 21:48:29.000000000 +0200
> +++ linux-2.6.12/drivers/ide/ide-floppy.c 2005-06-25
> 03:29:45.000000000 +0200
> @@ -125,7 +125,14 @@
> /*
> * Some drives require a longer irq timeout.
> */
> +#if 0
> #define IDEFLOPPY_WAIT_CMD (5 * WAIT_CMD)
> +#endif
> +#if 0
> +#define IDEFLOPPY_WAIT_CMD 200 /* --ms */
> +#endif
> +#define IDEFLOPPY_WAIT_CMD WAIT_CMD /* 2004/12/31
> --ms */
> +
>
> /*
> * After each failed packet command we issue a request sense
> command
> @@ -317,7 +324,13 @@
> unsigned long flags;
> } idefloppy_floppy_t;
>
> +#if 0
> #define IDEFLOPPY_TICKS_DELAY 3 /* default delay for ZIP 100 */
> +#define IDEFLOPPY_TICKS_DELAY 6 /* default delay for ZIP 100
> --ms 2005/01/01 */
> +#define IDEFLOPPY_TICKS_DELAY 12 /* default delay for ZIP 100
> --ms 2005/01/01 */
> +#endif
> +#define IDEFLOPPY_TICKS_DELAY 60 /* default delay for ZIP 100
> --ms 2005/01/07 */
> +
This seems to be basically what your patch changes, along with the
expiry addition. Neither of which should make any change in performance,
since you should normally not time commands out. Do you normally get
lots of errors or timeouts running that workload?
I don't see how your patch changes anything for a normally running
ide-floppy.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |