Re: Problems with Firewire and -mm kernels

[Dan Dennedy <dan@dennedy.org>]

On Thu, 2005-06-30 at 23:18 -0400, Ben Collins wrote:
> Most of this is class_simple changes.
> 
> However, there is a huge set of changes to sbp2. One thing that sticks out
> is the entire sbp2_check_sbp2_command() function being ripped out. There's
> some changes related to TYPE_SDAD devices (where did this come from?).

This is the TYPE_RBC cache fixes patch by Al Viro. That discussion went
on for a while with additional changes suggested, and I did not know the
resolution. Now we do. :-)

> Try reverting just the sbp2.[ch] changes from the 2.6.13-rc1 tree.
> 
> I'll see if I can figure out why our tree and kernel tree have gotten so
> far out of whack and how such huge changes that don't seem to fix anything

Obviously, much of the diff Rogerio produced (not in history below)
shows changes in our repo not yet submitted to kernel.

> (like the large changes to sbp2) have gotten into the kernel proper
> without being tested. Most of the sbp2 changes seem to be a new feature
> rather than fixing minor or even major bugs.
> 
> On Thu, Jun 30, 2005 at 11:44:33PM -0300, Rog?rio Brito wrote:
> > On Jun 30 2005, Ben Collins wrote:
> > > Also, have you tried using 2.6.13-rc1 using linux1394.org's subversion tree?
> > 
> > Here is what I get when I try to substitute 2.6.13-rc1 with linux1394
> > trunk's tree:
> > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> > (...)
> >   CC [M]  drivers/block/loop.o
> >   CC [M]  drivers/block/pktcdvd.o
> >   CC [M]  drivers/block/cryptoloop.o
> >   CC [M]  drivers/char/agp/intel-agp.o
> >   CC [M]  drivers/ieee1394/ieee1394_core.o
> > drivers/ieee1394/ieee1394_core.c: In function `hpsbpkt_thread':
> > drivers/ieee1394/ieee1394_core.c:1048: error: too many arguments to function `refrigerator'
> > drivers/ieee1394/ieee1394_core.c: In function `ieee1394_init':
> > drivers/ieee1394/ieee1394_core.c:1127: warning: implicit declaration of function `class_simple_create'
> > drivers/ieee1394/ieee1394_core.c:1127: warning: assignment makes pointer from integer without a cast
> > drivers/ieee1394/ieee1394_core.c:1165: warning: implicit declaration of function `class_simple_destroy'
> > make[3]: *** [drivers/ieee1394/ieee1394_core.o] Error 1
> > make[2]: *** [drivers/ieee1394] Error 2
> > make[1]: *** [drivers] Error 2
> > make[1]: Leaving directory `/usr/local/media/progs/linux/linux'
> > make: *** [stamp-build] Error 2
> > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> > 
> > Thanks, Rog?rio Brito.
> > 
> > -- 
> > Rog?rio Brito : rbrito@ime.usp.br : http://www.ime.usp.br/~rbrito
> > Homepage of the algorithms package : http://algorithms.berlios.de
> > Homepage on freshmeat:  http://freshmeat.net/projects/algorithms/
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/