Re: [PATCH] multipath routing algorithm, better patch

[Patrick McHardy <kaber@trash.net>]

Patrick Jenkins wrote:
> Hi,
> 
> The last patch wont work, this should.
> 
> This patch assigns the multipath routing algorithm into the fib_info
> struct's fib_mp_alg variable. Previously, the algorithm was always set to
> IP_MP_ALG_NONE which was incorrect. This patch corrects the problem by
> assigning the correct value when a fib_info is initialized.
> 
> This patch was tested against kernel 2.6.12.1 for all multipath routing
> algorithms (none, round robin, interface round robin, random, weighted
> random).

Multiple algorithms can be compiled in at once, so this patch is wrong.
mp_alg is supplied by userspace:

        if (rta->rta_mp_alg) {
                mp_alg = *rta->rta_mp_alg;

                if (mp_alg < IP_MP_ALG_NONE ||
                    mp_alg > IP_MP_ALG_MAX)
                        goto err_inval;
        }

If it isn't set correctly its an iproute problem. Did you actually
experience any problems?

Regards
Patrick
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/