Re: [PATCH] xip cleanups

[Christoph Hellwig <hch@lst.de>]

On Tue, Jun 28, 2005 at 02:21:09PM +0200, Arnd Bergmann wrote:
> On Dinsdag 28 Juni 2005 14:01, Christoph Hellwig wrote:> ?int> -ext2_clear_xip_target(struct inode *inode, int block) {> -???????sector_t sector = block*(PAGE_SIZE/512);> +ext2_clear_xip_target(struct inode *inode, int block)> +{> +???????sector_t sector = block * (PAGE_SIZE/512);> ????????unsigned long data;> ????????int rc;> ?> ????????rc = __inode_direct_access(inode, sector, &data);> -???????if (rc)> -???????????????return rc;> -???????clear_page((void*)data);> -???????return 0;> +???????if (!rc)> +???????????????clear_page(data);> +???????return rc;> ?}
> Did you try building it? While most of your changes areobviously correct, passing an unsigned long value to clear_pagewithout a cast isn't.

On what hardware? ;-)  Ok, that one is indeed bogus.

Btw, you mailer totally messed up the quoted part.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/