Re: [PATCH 8/13]: PCI Err: Event delivery utility

[Linas Vepstas <linas@austin.ibm.com>]

On Thu, Jun 30, 2005 at 09:42:01AM +1000, Benjamin Herrenschmidt was heard to remark:
> On Wed, 2005-06-29 at 16:14 -0500, Linas Vepstas wrote:
> 
> > I'm pretty sure this was balanced, there is a get very early on when the
> > error is detected.  But I'll review.
> > 
> > > I'd keep that in arch code for now.
> > 
> > OK, I'm moving it there. It did seem both confusing and semi-pointless
> > after the last round of changes.
> 
> Well, it's logical for the get and put to be in the same "layer" don't
> you think ?

Yes, it could be made more symmetrical; I'll do that.

The get happened along with the malloc of the event structure, the put
happens right before the free of the same structure.  

The reason for the event was in order to get the recovery of the error
out of line from the detection of the error; detection may occur in an
interrupt context; recovery happens in a work queue.  Thus, get may
happen in that interrupt context, the put only after the work is
complete.

I'll make the code more symmetrical with regards to the event malloc/free
and that should make it more readable.

--linas

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/