Re: [PATCH] clean up inline static vs static inline

[Jesper Juhl <juhl@dif.dk>]

On Wed, 29 Jun 2005, Jesper Juhl wrote:

> 
> Andrew, I know you generally don't want to take patches for stuff that 
> only fixes gcc -W warnings except through maintainers, but this one I 
> found to be so obviously correct that I desided to take the chance anyway 
> - especially since you've taken patches like this one in the past. :-)
> Lets merge this and get rid of this little annoyance once and for all.
> 
> gcc likes to complain if the static keyword is not at the beginning of the 
> declaration. This patch fixes all remaining occurrences of "inline static" 
> up with "static inline" in the entire kernel tree (140 occurrences in 47 
> files).
> While making this change I came across a few lines with trailing 
> whitespace that I also fixed up, I have also added or removed a blank line 
> or two here and there, but there are no functional changes in the patch.
> 

Whoops, forgot the Signed-off-by and diffstat - here they are : 

Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
---

 arch/ia64/sn/include/pci/pcibr_provider.h |    2 +-
 crypto/aes.c                              |    2 +-
 drivers/cdrom/optcd.c                     |   28 ++++++++++++++--------------
 drivers/char/ipmi/ipmi_si_intf.c          |    2 +-
 drivers/ide/pci/cmd640.c                  |    2 +-
 drivers/isdn/hisax/avm_a1.c               |    2 +-
 drivers/isdn/hisax/isdnl2.c               |    2 +-
 drivers/isdn/hisax/teles3.c               |    2 +-
 drivers/md/md.c                           |    2 +-
 drivers/media/radio/radio-maestro.c       |    4 ++--
 drivers/media/radio/radio-maxiradio.c     |    2 +-
 drivers/mmc/wbsd.c                        |    2 +-
 drivers/net/3c505.c                       |    2 +-
 drivers/net/plip.c                        |   29 ++++++++++++++---------------
 drivers/net/via-velocity.h                |    4 ++--
 drivers/net/wireless/airo.c               |    2 +-
 drivers/oprofile/cpu_buffer.c             |   23 +++--------------------
 drivers/s390/cio/qdio.c                   |   20 ++++++++++----------
 drivers/s390/net/qeth.h                   |   26 +++++++++++++-------------
 drivers/scsi/dc395x.c                     |    2 +-
 drivers/scsi/fdomain.c                    |    2 +-
 drivers/usb/image/microtek.c              |    3 +--
 drivers/video/pm2fb.c                     |   16 ++++++++--------
 fs/reiserfs/journal.c                     |    4 ++--
 include/sound/vx_core.h                   |   16 ++++++++--------
 kernel/time.c                             |    2 +-
 net/core/pktgen.c                         |    2 +-
 sound/core/seq/oss/seq_oss_device.h       |    6 +++---
 sound/core/seq/seq_memory.c               |    4 ++--
 sound/core/seq/seq_midi_event.c           |    2 +-
 sound/drivers/serial-u16550.c             |   10 +++++-----
 sound/isa/sb/emu8000_patch.c              |    2 +-
 sound/oss/dmasound/dmasound_awacs.c       |    4 ++--
 sound/pci/cmipci.c                        |   14 ++++++++------
 sound/pci/cs4281.c                        |    2 +-
 sound/pci/emu10k1/memory.c                |    2 +-
 sound/pci/es1968.c                        |   12 ++++++------
 sound/pci/maestro3.c                      |    8 ++++----
 sound/pci/nm256/nm256.c                   |   16 ++++++++--------
 sound/pci/trident/trident_main.c          |    2 +-
 sound/pci/trident/trident_memory.c        |    2 +-
 sound/pci/vx222/vx222_ops.c               |    4 ++--
 sound/pcmcia/vx/vxp_ops.c                 |    2 +-
 sound/ppc/burgundy.c                      |    4 ++--
 sound/ppc/pmac.c                          |    8 ++++----
 sound/usb/usbaudio.c                      |    8 ++++----
 sound/usb/usbmixer.c                      |    4 ++--
 47 files changed, 152 insertions(+), 169 deletions(-)


I've attached the patch (gzip'ed due to size) to this mail - it was inline 
in the previous one, but not sure if it'll make it to you since that mail 
was ~50K


-- Jesper

Attachment: inline_static-vs-static_inline.patch.gz
Description: inline_static-vs-static_inline.patch.gz