Re: [05/07] Add "memory" clobbers to the x86 inline asm of strncmp and friends

[Jean Delvare <khali@linux-fr.org>]

Hi Chris,

> @@ -138,8 +139,9 @@ __asm__ __volatile__(
>  	"3:\tsbbl %%eax,%%eax\n\t"
>  	"orb $1,%%al\n"
>  	"4:"
> -		     :"=a" (__res), "=&S" (d0), "=&D" (d1), "=&c" (d2)
> -		     :"1" (cs),"2" (ct),"3" (count));
> +	:"=a" (__res), "=&S" (d0), "=&D" (d1), "=&c" (d2)
> +	:"1" (cs),"2" (ct),"3" (count)
> +	:"memory");
>  return __res;
>  }

Could be made shorter. As far as I remember, indentation fixes are not
-stable material.

> @@ -369,7 +379,7 @@ __asm__ __volatile__(
>  	"je 2f\n\t"
>  	"stosb\n"
>  	"2:"
> -	: "=&c" (d0), "=&D" (d1)
> +	:"=&c" (d0), "=&D" (d1)
>  	:"a" (c), "q" (count), "0" (count/4), "1" ((long) s)
>  	:"memory");
>  return (s);	

Doesn't belong there, unless -stable rules have changed.

Thanks,
-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/