Re: [PATCH] ppc/ppc64: Fix pci mmap via sysfs

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Sunday, June 26, 2005 7:11 pm, Benjamin Herrenschmidt wrote:
> On Sun, 2005-06-26 at 18:57 -0700, Andrew Morton wrote:
> > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > > Hi !
> > >
> > > This implement the change to /proc and sysfs PCI mmap functions
> > > that we discussed a while ago, that is adding an arch optional
> > > pci_resource_to_user() to allow munging on the exposed value of
> > > PCI resources to userland and thus hiding kernel internal values.
> > > It also implements using of that callback to sanitize exposed
> > > values on ppc an ppc64, thus fixing mmap of PCI devices via /proc
> > > and sysfs.
> >
> > You sure you want all those printks in there?
>
> One quilt ref later ... :)

This one looks better. :)  Thanks for fixing this up.

Please document it in sysfs-pci.txt too (I guess we don't have a similar 
document for /proc/bus/pci unfortunately) so that people won't miss it 
when they implement /proc/bus/pci and sysfs PCI mmap support in the 
future.

Thanks,
Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/