Re: [RFC,PATCH] RCU: clean up a few remaining synchronize_kernel() calls

[Zwane Mwaikambo <zwane@arm.linux.org.uk>]

On Tue, 28 Jun 2005, Paul E. McKenney wrote:

> awake...  How about the following instead?
> 
> 	void set_nmi_callback(nmi_callback_t callback)
> 	{
> 		rcu_assign_pointer(nmi_callback, callback);
> 	}
> 
> Similarly:
> 
> 	void unset_nmi_callback(void)
> 	{
> 		rcu_assign_pointer(nmi_callback, dummy_nmi_callback);
> 	}

Great, more API coverage is always better.

> This, combined with the rcu_dereference() in do_nmi() seem to me to
> make the usage a lot more clear.  If you agree, would you like to
> submit the patches, or should I?

You go ahead.

> > Thanks for elaborating, the examples certainly do help clarify usage.
> 
> Glad they help, will clean them up (so that the examples use
> rcu_dereference() and rcu_assign_pointer()) and submit them!

Thanks,
	Zwane

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/