Re: [CFT:PATCH] 2/3: Check status of CTS when using flow control

[Russell King <rmk+lkml@arm.linux.org.uk>]

On Sun, Jun 26, 2005 at 11:17:50PM +0100, Russell King wrote:
> Fix bugme #4712: read the CTS status and set hw_stopped if CTS
> is not active.
> 
> Thanks to Stefan Wolff for spotting this problem.

Stefan Wolff pointed out that this wasn't quite correct.  Here's an
updated patch.

Index: drivers/serial/serial_core.c
===================================================================
--- 61f26f0bd348c6ddac8b3b1105e00fa790ea3ea6/drivers/serial/serial_core.c  (mode:100644)
+++ uncommitted/drivers/serial/serial_core.c  (mode:100644)
@@ -182,6 +182,13 @@
 				uart_set_mctrl(port, TIOCM_RTS | TIOCM_DTR);
 		}
 
+		if (info->flags & UIF_CTS_FLOW) {
+			spin_lock_irq(&port->lock);
+			if (!(port->ops->get_mctrl(port) & TIOCM_CTS))
+				info->tty->hw_stopped = 1;
+			spin_unlock_irq(&port->lock);
+		}
+
 		info->flags |= UIF_INITIALIZED;
 
 		clear_bit(TTY_IO_ERROR, &info->tty->flags);
@@ -1134,6 +1141,16 @@
 		spin_unlock_irqrestore(&state->port->lock, flags);
 	}
 
+	/* Handle turning on CRTSCTS */
+	if (!(old_termios->c_cflag & CRTSCTS) && (cflag & CRTSCTS)) {
+		spin_lock_irqsave(&state->port->lock, flags);
+		if (!(state->port->ops->get_mctrl(state->port) & TIOCM_CTS)) {
+			tty->hw_stopped = 1;
+			state->port->ops->stop_tx(state->port, 0);
+		}
+		spin_unlock_irqrestore(&state->port->lock, flags);
+	}
+
 #if 0
 	/*
 	 * No need to wake up processes in open wait, since they


-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/