Andrew Morton wrote:
> Johannes Stezenbach <[email protected]> wrote:
> >
> > From: Adrian Bunk <[email protected]>
> >
> > The Coverity checker discovered that these two kfree's can never be
> > executed.
> >
>
> That's a bit strange - the code was OK beforehand. It's a bit of a tossup.
Hm, the comment was a bit misleading, but the kfree(NULL) is a no-op.
> > /* allocate memory for the internal state */
> > state = (struct ttusbdecfe_state*) kmalloc(sizeof(struct ttusbdecfe_state), GFP_KERNEL);
>
> This typecast is unneeded btw. We tend to avoid casts to and from void*
> because they defeat typechecking and uglify things.
I just passed the patch on unchanged. The void-cast cleanup is for
another patch (the issue is known and we already cleaned up quite
a lot of them).
Johannes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
