Re: [RFC] Driver writer's guide to sleeping

[Denis Vlasenko <vda@ilport.com.ua>]

On Sunday 26 June 2005 22:38, Oliver Neukum wrote:
> Am Samstag, 25. Juni 2005 13:54 schrieb Denis Vlasenko:
> > On Saturday 25 June 2005 14:29, Oliver Neukum wrote:
> > > On Sat, 25 Jun 2005, Denis Vlasenko wrote:
> > > 
> > > > schedule_timeout(timeout)
> > > > 	Whee, it has a comment! :)
> > > >  * %TASK_UNINTERRUPTIBLE - at least @timeout jiffies are guaranteed to
> > > >  * pass before the routine returns. The routine will return 0
> > [snip]
> > > > 	Thus:
> > > > 	set_current_state(TASK_[UN]INTERRUPTIBLE);
> > > > 	schedule_timeout(timeout_in_jiffies)
> > > > 
> > > > msleep(ms)
> > > > 	Sleeps at least ms msecs.
> > > > 	Equivalent to:
> > > > 	set_current_state(TASK_UNINTERRUPTIBLE);
> > > > 	schedule_timeout(timeout)
> > > 
> > > If and only if you are not on any waitqueue. You may not be interrupted
> > > by a signal, but you still can be woken with an explicit wake_up()
> > 
> > Like this?
> 
> Yes, but we have macros for that. You are supposed to use them.

Erm.. I meant "Shall we correct that comment then, like this?".
Comment is plain wrong now.
--
vda

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/