Re: [RFC] SPI core -- revisited

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alexey Dobriyan wrote:

+static void        *phys_spi_data_reg = 0;


NULL for pointers.

+void spipnx_select_chip (void)
+{
+    unsigned reg = gpio_read_reg (PADMUX1_MODE0);
+    gpio_write_reg ((reg & ~GPIO_PIN_SPI_CE), PADMUX1_MODE0); }


Closing brackets on the separate line, _please_.

+static void spipnx_spi_init (void *algo_data) {


As well as opening ones.

--- /dev/null
+++ linux-2.6.10/drivers/spi/spi-pnx010x_atmel.c


Hm, as far as I understand, this patch is not intended to become a part of kernel; neither it is posted to go through a formal review. It's just an example usage of the SPI core, isn't it?

What I would like to see, however, is dealing with the scatter-gather lists. I guess this should be in algorithm, isn't it?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux