> +
> + /* generate SMI */
> + asm("outb %b0,%w1" : :
> + "a" (ci_cmd->command_code),
> + "d" (ci_cmd->command_address),
> + "b" (command_buffer_phys_addr),
> + "c" (ci_cmd->signature));
> +
Is there a reason this bit is asm not an outb() macro. If its needed in
asm for the SMI behaviour then document that fact so nobody "optimises"
it.
> + unsigned long size;
> + int ret;
> + size = sizeof(struct dcdbas_ioctl_hdr) + hdr.data_size;
Can this not underflow if hdr.data_size is passed in very large
There are a few others like that which look like they might need
overflow checks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]