Re: [ANNOUNCE] ORT - Oops Reporting Tool

[Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>]

2005/6/26, Christian Kujau <evil@g-house.de>:
> Paolo Ciarrocchi wrote:
> >
> > The commands that are requiring root capabilties are:
> > lspci -vvv
> > lsusb -v
> 
> i still dislike the idea being forced to be root, does the attached patch
> looks ok?

Just for my understanding, why do you dislike to be forced to be root ?
You are reporting a kernel problem, I don't see any problem in being
root, but I donìt have a clear understing of pro and cons.

> --- ort/ort.sh.orig     2005-06-25 23:42:22.000000000 +0200
> +++ ort/ort.sh  2005-06-25 23:54:32.000000000 +0200
> @@ -34,7 +34,6 @@ EM_CLI=mutt
> 
> help() {
>     echo "Usage: [root@mylinuxbox ~]$ ./ort.sh oops.txt"
> -    echo "You need to be root [uid=0] to run the script"
>     exit 1
> }
> 
> @@ -53,7 +52,12 @@ cmd_line() {
> check_uid() {
>     if [ $UID != "0" ]
>        then
> -           help
> +           echo -n "You should be root [uid=0] to run the script, continue? [y,n]  "
> +           read c
> +           if [ "$c" != "y" ]; then
> +               echo "Aborted."
> +               exit 1
> +           fi
>     fi
> }

This is fine with me.
 
> @@ -274,7 +278,7 @@ point_7_4() {
> 
> point_7_5() {
>     echo -e "\n[7.5.] PCI information" >> $ORT_F
> -    lspci -vvv >> $ORT_F
> +    env PATH=/bin:/usr/bin:/sbin:/usr/sbin lspci -vvv >> $ORT_F

What's the benefit of this change ?

> }
> 
> point_7_6() {
> @@ -286,7 +290,7 @@ point_7_6() {
> 
> point_7_7() {
>     echo -e "\n[7.7.] USB information" >> $ORT_F
> -    lsusb -v >> $ORT_F
> +    env PATH=/bin:/usr/bin:/sbin:/usr/sbin lsusb -v >> $ORT_F
> }
> 
> point_7_8() {
> 
> 


-- 
Paolo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/