Re: [PATCH] I2O: Lindent run and replacement of printk through osm printing functions

[Jeff Garzik <jgarzik@pobox.com>]

Markus Lidel wrote:
> Hello,
>
> Jeff Garzik wrote:
>
> > Linux Kernel Mailing List wrote:
> >
> > > tree da7e51e7204625f21371eac23a931f4fe479e9db
> > > parent 9e87545f06930c1d294423a8091d1077e7444a47
> > > author Markus Lidel <Markus.Lidel@shadowconnect.com> Fri, 24 Jun 2005 
> > > 12:02:23 -0700
> > > committer Linus Torvalds <torvalds@ppc970.osdl.org> Fri, 24 Jun 2005 
> > > 14:05:29 -0700
> > > [PATCH] I2O: Lindent run and replacement of printk through osm 
> > > printing functions
> > > Lindent run and replaced printk() through the corresponding osm_*() 
> > > function
> >
> > Please don't combine ANY code changes with an Lindent patch.
>
>
> Also if there is no functional change, only cosmetical (the osm_*() 
> function just mappes to printk(*, ...))?

Yes.  An Lindent patch needs to contain absolutely nothing else, not 
even documentation changes.

The rationale is that it is extremely difficult for reviewers to review 
your non-Lindent changes, because they are so obscured by Lindent.

In the past, one person even hid a [valid] security fix inside an 
Lindent patch.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/