[TPM] broken /proc/misc entry

[Jochen Hein <jochen@jochen.org>]

On my system I do have configured:

root@hermes:/dev# grep TPM /usr/src/linux-2.6.12/.config
# TPM devices
CONFIG_TCG_TPM=m

TPM is loaded:
root@hermes:/dev# lsmod | grep tpm
tpm_nsc                 6272  0
tpm_atmel               4992  0
tpm                    10496  2 tpm_nsc,tpm_atmel

/proc/misc contains:

root@hermes:/dev# cat /proc/misc
224
ZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZ!
 63 device-mapper
200 tun
  1 psaux
175 agpgart
130 watchdog
144 nvram
135 rtc

After I removed the TPM modules I get:
root@hermes:/dev# rmmod tpm_nsc
root@hermes:/dev# rmmod tpm_atmel
root@hermes:/dev# rmmod tpm
root@hermes:/dev# cat /proc/misc
 63 device-mapper
200 tun
  1 psaux
175 agpgart
130 watchdog
144 nvram
135 rtc

Why on earth do we need to obfuscate the loaded TPM modules and the
misc minor number in that way?  ls -l /dev/tpm gave that away easily.

>From the source:

        if (misc_register(&chip->vendor->miscdev)) {
                dev_err(&chip->pci_dev->dev,
                        "unable to misc_register %s, minor %d\n",
                        chip->vendor->miscdev.name,
                        chip->vendor->miscdev.minor);
                pci_dev_put(pci_dev);
                kfree(chip);
                dev_mask[i] &= !(1 << j);
                return -ENODEV;
        }

Maybe it's a bad idea to use &chip->vendor->miscdev for registering
the misc device?

Jochen

-- 
#include <~/.signature>: permission denied
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/