Re: [linux-usb-devel] usb sysfs intf files no longer created when probe fails

[Stelian Pop <stelian@popies.net>]

Le mercredi 22 juin 2005 à 12:03 -0400, Alan Stern a écrit :
> On Wed, 22 Jun 2005, Stelian Pop wrote:
> 
> > Notice the '1-2:1.1' is missing. Upon booting I get:
> > 
> > Jun 22 13:34:04 localhost kernel: HID device not claimed by input or hiddev
> > Jun 22 13:34:04 localhost kernel: usbhid: probe of 1-2:1.1 failed with error -5
> > Jun 22 13:34:04 localhost kernel: usb 1-2: device_add(1-2:1.1) --> -5

> You shouldn't call usb_create_sysfs_intf_files in any case.

Ok.

> Your driver is returning -EIO from its probe routine according to the log,
> so it's not getting bound to the device. 

Actually that's usbhid which returns -EIO.

>  Hence there shouldn't be any
> attempt to unbind the device when your driver is removed.  This is a bug
> in usbcore; it tries to delete all the interfaces without checking whether 
> they were successfully added.

Since this is fixed by reverting the device_add patch, I'm wondering if
this isn't a driver model core bug, where it tries to device_remove all
the "devices" even if they weren't correctly added before...

But I haven't looked closely at the code, this is just a thought.

Stelian.
-- 
Stelian Pop <stelian@popies.net>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/