On Jun 21, 2005, at 4:34 PM, Arnd Bergmann wrote:
+union MFC_TagSizeClassCmd {
I think great effort has gone in to removing so-called "StudlyCaps"
from the ppc64 iSeries code... :)
Also, I didn't see "MFC" defined anywhere... it's sort of a pet peeve,
but could you make sure all your acronyms are defined? Most of them are
described in spu.h, but a few slipped through I think (like "SMF").
And while a comment at the top of every file is great, ones like this:
+/*
+ * Low-level SPU handling
+ *
might be more helpful if they defined SPU and further mentioned it's
the coprocessor in the Broadband Processor Architecture...
-Hollis
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]