hoi :) On Mon, Jun 20, 2005 at 01:38:00PM -0700, Andrew Morton wrote: > Yes, it is cleaner that way. Well, I don't think so... > The old trick to make the error-handling code out-of-line shouldn't be > needed nowadays - IS_ERR uses unlikely(), which is supposed to handle that > stuff. IMHO out-of-line error handling improves readability because you have a clear boundary between real functionality and error handling. If both are mixed up you have to look longer at the code to understand the control-flow. -- Martin Waitz
Attachment:
signature.asc
Description: Digital signature
- Follow-Ups:
- References:
- [PATCH] Replaces two GOTO statements with one IF_ELSE statement in /fs/open.c
- From: Telemaque Ndizihiwe <[email protected]>
- Re: [PATCH] Replaces two GOTO statements with one IF_ELSE statement in /fs/open.c
- From: Jeff Garzik <[email protected]>
- Re: [PATCH] Replaces two GOTO statements with one IF_ELSE statement in /fs/open.c
- From: Christoph Lameter <[email protected]>
- Re: [PATCH] Replaces two GOTO statements with one IF_ELSE statement in /fs/open.c
- From: Andrew Morton <[email protected]>
- [PATCH] Replaces two GOTO statements with one IF_ELSE statement in /fs/open.c
- Prev by Date: Re: [PATCH] devfs: Remove the tty_driver devfs_name field as it's no longer needed
- Next by Date: Re: [PATCH 1/2] I-pipe: Core implementation
- Previous by thread: Re: [PATCH] Replaces two GOTO statements with one IF_ELSE statement in /fs/open.c
- Next by thread: Re: [PATCH] Replaces two GOTO statements with one IF_ELSE statement in /fs/open.c
- Index(es):
 |