Re: [patch 2/2] kernel/power/disk.c string fix and if-less iterator

On Tue, 21 June 2005 00:10:41 +0200, Pavel Machek wrote:
> 
> > The attached patch:
> > 
> > o  Fixes kernel/power/disk.c string declared as 'char *p = "...";' to be
> >    declared as 'char p[] = "...";', as pointed by Jeff Garzik.
> 
> ? Why was char *p ... wrong? Because you could not do sizeof() later?

Not necessarily wrong, but iirc, "*p" can waste 4 bytes (or 8, for
64-bit platforms).  Since this variable isn't static, that's a
non-issue, but I've seen it on some kernel-janitor list anyway.

Jörn

-- 
Those who come seeking peace without a treaty are plotting.
-- Sun Tzu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 2/2] kernel/power/disk.c string fix and if-less iterator
    • From: [email protected]
  • Re: [patch 2/2] kernel/power/disk.c string fix and if-less iterator
    • From: Pavel Machek <[email protected]>

• Prev by Date: Re: PATCH: Fix crashes with hotplug serverworks
• Next by Date: Re: [patch 2/2] kernel/power/disk.c string fix and if-less iterator
• Previous by thread: Re: [patch 2/2] kernel/power/disk.c string fix and if-less iterator
• Next by thread: Re: [patch 2/2] kernel/power/disk.c string fix and if-less iterator
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]