Re: 2.6.12-mm1

[Ethan Benson <erbenson@alaska.net>]

On Mon, Jun 20, 2005 at 04:57:51PM +1000, Benjamin Herrenschmidt wrote:
> 
> On Sun, 2005-06-19 at 23:30 -0700, Andrew Morton wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12/2.6.12-mm1/
> > 
> > 
> > - Someone broke /proc/device-tree on ppc64.  It's being looked into.
> 
> I did, the breakage is in 2.6.12, and no, it's not broken :)
> 
> The problem is that the "ofpath" script that is part of the yaboot
> package has a stupid bug where for some reason, when booting from SCSI
> (or libata in this case), it decides to check wether there are any
> symlinks in /proc/device-tree, and if not, decides it's broken and
> aborts. It doesn't actually make any use of the symlinks that were there
> though (and they were useless and partially broken anyway, which is why
> I removed them).

this check was done because of BootX, which caused a broken and
unusable device-tree.

> So it's a bug in "ofpath", a bit annoying, but at the same time, you
> don't need to run it when changing kernels, so it's not too harmful.
> 
> The fix is :

so long as BootX is no longer in use, yes.

> --- ofpath	2005-06-20 16:56:12.000000000 +1000
> +++ ofpath.patched	2005-06-20 16:57:00.000000000 +1000
> @@ -425,14 +425,6 @@
>  {
>      case "$DEVNODE" in
>  	sd*)
> -	    if ls -l /proc/device-tree | grep -q ^lr ; then
> -		true
> -	    else
> -		echo 1>&2 "$PRG: /proc/device-tree is broken.  Do not use BootX to boot, use yaboot."
> -		echo 1>&2 "$PRG: The yaboot HOWTO can be found here: http://www.alaska.net/~erbenson/doc";
> -		return 1
> -	    fi
> -
>  	    ## use common scsiinfo function to get info we need.
>  	    scsiinfo || return 1
>  
> 
> -- 
> To UNSUBSCRIBE, email to minimalist@lists.penguinppc.org
> with a subject of "unsubscribe yaboot-devel". Trouble? Contact listmaster@lists.penguinppc.org

-- 
Ethan Benson
http://www.alaska.net/~erbenson/

Attachment: pgpMBGJ47LoAB.pgp
Description: PGP signature