[PATCH] drivers/char/tipar.c: off by one array access

In the setupt function, the delay variable is initialized with ints[2],
but ints is declared as:
	int ints[2];

Since the module parameter should correspond to:
	tipar=timeout,delay

I suppose that the following patch fix the problem.


Signed-off-by: Luc Van Oostenryck <[email protected]>

diff --git a/drivers/char/tipar.c b/drivers/char/tipar.c
--- a/drivers/char/tipar.c
+++ b/drivers/char/tipar.c
@@ -407,7 +407,7 @@ tipar_setup(char *str)
                         printk(KERN_WARNING "tipar: bad timeout value (0), "
 				"using default value instead");
 		if (ints[0] > 1) {
-			delay = ints[2];
+			delay = ints[1];
 		}
 	}



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] drivers/char/tipar.c: off by one array access
    • From: randy_dunlap <[email protected]>

• Prev by Date: Re: 2.6.12 udev hangs at boot
• Next by Date: Re: 2.6.12 udev hangs at boot
• Previous by thread: [PATCH 2.6.12] usb: Makefile update for SISUSBVGA
• Next by thread: Re: [PATCH] drivers/char/tipar.c: off by one array access
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]