Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver

On Wed, Jun 15, 2005 at 12:59:46PM -0500, Abhay Salunke wrote:
> +static struct device rbu_device_mono;
> +static struct device rbu_device_packet;
> +static struct device rbu_device_cancel;

You should never create a struct device on the stack.  Lots of bad
things can happen (including not having a release function for them.)

Why not just point to the cpu device, or some other platform or system
device?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver
    • From: Abhay Salunke <[email protected]>

• Prev by Date: Re: [PATCH] ReiserFS _get_block_create_0 wrong behavior when I/O fails
• Next by Date: Re: [RFD] FS behavior (I/O failure) in kernel summit
• Previous by thread: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver
• Next by thread: Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]