[PATCH] fix gcc -W warning in netdevice.h

[Jesper Juhl <juhl-lkml@dif.dk>]

This might be a slightly controversial patch in that it adds a cast purely 
to shut up a gcc -W warning, but this header file is used in *lots* of 
places, so when building with gcc -W this warning shows up all over the 
place :
	include/linux/netdevice.h:781: warning: comparison between signed and unsigned
With my normal .config I over 120 instances of this one, so shutting it up 
cuts down on the stuff I have to wade through to try and spot real 
potential problems quite a bit.
The cast is completely harmless since the unsigned value that gcc is 
complaining about will never exceed the storage capacity of a plain int, 
and it will not change any actual code behaviour.

Please consider merging.


Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
---

 include/linux/netdevice.h |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.12-rc6-mm1-orig/include/linux/netdevice.h	2005-06-12 15:58:58.000000000 +0200
+++ linux-2.6.12-rc6-mm1/include/linux/netdevice.h	2005-06-16 00:52:14.000000000 +0200
@@ -778,7 +778,7 @@ enum {
 static inline u32 netif_msg_init(int debug_value, int default_msg_enable_bits)
 {
 	/* use default */
-	if (debug_value < 0 || debug_value >= (sizeof(u32) * 8))
+	if (debug_value < 0 || debug_value >= (int)(sizeof(u32) * 8))
 		return default_msg_enable_bits;
 	if (debug_value == 0)	/* no output */
 		return 0;



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/