On Wed, Jun 15, 2005 at 01:38:49AM -0500, Dmitry Torokhov wrote:
> Hi Linus, Vojtech,
>
> It looks like logic for enabling hardware tapping in ALPS driver was
> inverted and we enable it only if it was already enabled by BIOS or
> firmware.
>
> I have a confirmation from one user that the patch below fixes the
> problem for him and it might be beneficial if we could get it into
> 2.6.12.
Linus, Andrew, please include this patch. I don't have a git tree setup
yet for pulls, and it won't be ready before 2.6.12, however this patch
should definitely go in.
Thanks,
Vojtech
> Thanks!
>
> --
> Dmitry
>
> ===================================================================
>
> Input: ALPS - try enabling tap mode if it was disabled, not if
> it is already enabled.
>
> Signed-off-by: Dmitry Torokhov <[email protected]>
> ---
>
> drivers/input/mouse/alps.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: work/drivers/input/mouse/alps.c
> ===================================================================
> --- work.orig/drivers/input/mouse/alps.c
> +++ work/drivers/input/mouse/alps.c
> @@ -364,7 +364,7 @@ static int alps_reconnect(struct psmouse
> if (alps_get_status(psmouse, param))
> return -1;
>
> - if (param[0] & 0x04)
> + if (!(param[0] & 0x04))
> alps_tap_mode(psmouse, 1);
>
> if (alps_absolute_mode(psmouse)) {
>
--
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
