On Sunday 12 June 2005 14:22, Mikael Pettersson wrote:
> On i386 gcc4 generates a few compile-time warnings like:
>
> process.c:556: warning: statement with no effect
> process.c:569: warning: statement with no effect
>
> This is because the i386 struct_cpy() macro references an
> undefined variable when its two operands differ in size,
> in the hope of turning a runtime error into a link-time error.
>
> However, a simple variable reference has no effect, which
> is why gcc4 complains.
>
> The fix is to change it to a call to an undefined function.
>
> Signed-off-by: Mikael Pettersson <[email protected]>
>
> include/asm-i386/string.h | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -rupN linux-2.4.31/include/asm-i386/string.h linux-2.4.31.gcc4-i386-struct_cpy-warnings/include/asm-i386/string.h
> --- linux-2.4.31/include/asm-i386/string.h 2001-08-12 11:35:53.000000000 +0200
> +++ linux-2.4.31.gcc4-i386-struct_cpy-warnings/include/asm-i386/string.h 2005-06-12 11:52:25.000000000 +0200
> @@ -337,7 +337,7 @@ extern void __struct_cpy_bug (void);
> #define struct_cpy(x,y) \
> ({ \
> if (sizeof(*(x)) != sizeof(*(y))) \
> - __struct_cpy_bug; \
> + __struct_cpy_bug(); \
> memcpy(x, y, sizeof(*(x))); \
> })
1) Don't you need a void __struct_cpy_bug(void) declaration before this
(as a matter of style, not correctness)?
2) Why __ ? It is not compiler- or library-special, why not
BUG_struct_cpy_different_sizes() or something like this?
--
vda
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
