> > I think we should also use the pm_message_t defines. We will need to
> > add PMSG_FREEZE eventually. I decided to default to the current state
> > rather than panic. Does this patch look ok?
>
> No.
Hrm... I don't follow you anymore here ...
> case PM_EVENT_ON:
> return PCI_D0;
> case PM_EVENT_FREEZE:
> case PM_EVENT_SUSPEND:
> return PCI_D3hot;
What are these new PM_EVENT_* things ? I though we defined PMSG_* ?
> You passed invalid argument; I see no reason why you should paper over
> it and risk continuing. This happens during system suspend; it is
> quite possible that user will not see your printk when machine powers
> off just after that; and remember that it will not be in syslog after
> resume.
Crap. I don't think a BUG() makes any useful help neither in this place,
and when I locally turn PMSG_FREEZE to something sane I suddenly blow up
in there (and I wonder in how many other places).
Ben.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
