Jeff Garzik wrote:
Tejun Heo wrote:02_blk_scsi_eopnotsupp.patch Use -EOPNOTSUPP instead of -EIO on ILLEGAL_REQUEST. Signed-off-by: Tejun Heo <[email protected]> scsi_lib.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletion(-) Index: blk-fixes/drivers/scsi/scsi_lib.c ===================================================================--- blk-fixes.orig/drivers/scsi/scsi_lib.c 2005-06-05 14:53:32.000000000 +0900 +++ blk-fixes/drivers/scsi/scsi_lib.c 2005-06-05 14:53:33.000000000 +0900@@ -849,7 +849,8 @@ void scsi_io_completion(struct scsi_cmnd scsi_requeue_command(q, cmd); result = 0; } else { - cmd = scsi_end_request(cmd, 0, this_count, 1); + cmd = scsi_end_request(cmd, -EOPNOTSUPP, + this_count, 1);This looks like a change from zero to EOPNOTSUPP, but your description says its a change from EIO to EOPNOTSUPP.Jeff
Hello, Jeff.I just found it confusing to write changing 0 to -EOPNOTSUPP when 0 actually means -EIO (uptodate). I'll write in more detailed way next time.
Thank you. :-) -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH Linux 2.6.12-rc5-mm2 00/09] blk: ordered request reimplementation (take 2, for review)
- From: Tejun Heo <[email protected]>
- Re: [PATCH Linux 2.6.12-rc5-mm2 02/09] blk: make scsi use -EOPNOTSUPP instead of -EIO on ILLEGAL_REQUEST
- From: Tejun Heo <[email protected]>
- Re: [PATCH Linux 2.6.12-rc5-mm2 02/09] blk: make scsi use -EOPNOTSUPP instead of -EIO on ILLEGAL_REQUEST
- From: Jeff Garzik <[email protected]>
- [PATCH Linux 2.6.12-rc5-mm2 00/09] blk: ordered request reimplementation (take 2, for review)
- Prev by Date: Re: [uml-devel] [PATCH 3/5] UML - Clean up tt mode remapping of UML binary
- Next by Date: Re: [SATA] libata-dev queue updated
- Previous by thread: Re: [PATCH Linux 2.6.12-rc5-mm2 02/09] blk: make scsi use -EOPNOTSUPP instead of -EIO on ILLEGAL_REQUEST
- Next by thread: Re: [PATCH Linux 2.6.12-rc5-mm2 03/09] blk: make ide use -EOPNOTSUPP instead of -EIO on ABRT_ERR
- Index(es):
 |