Re: pci_enable_msi() for everyone?

[Greg KH <gregkh@suse.de>]

On Sun, Jun 05, 2005 at 12:46:12PM -0700, David S. Miller wrote:
> From: Greg KH <gregkh@suse.de>
> Date: Fri, 3 Jun 2005 15:45:51 -0700
> 
> > Now I know the e1000 driver would have to specifically disable MSI for
> > some of their broken versions, and possibly some other drivers might
> > need this, but the downside seems quite small.
> > 
> > Or am I missing something pretty obvious here?
> 
> This is totally undesirable.  We don't want the device sending
> out MSI messages unless the driver for it explicitly knows
> that it is operating the device in this mode.

Why would it matter?  The driver shouldn't care if the interrupts come
in via the standard interrupt way, or through MSI, right?  And if it
does, it could always use a function like the one I proposed to set up a
different irq handler.

> TG3 will disable MSI for several chip variants as well.  It will
> also disable MSI if it's internal self-test of MSI functionality
> fails.

That's fine to disable msi, I don't have an issue with that.  I'm just
getting pushback from some vendors as to why MSI isn't explicitly
enabled by default and I don't have any solid answers.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/