RE: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new DellBIOS update driver

[<Abhay_Salunke@Dell.com>]

> > >
> > > No no no.  Just because you are using the firmware interface, does
not
> > > mean you need to add this extra round-trip to the whole system.
Just
> > > dump the firmware to the /sys/firmware/whatever... file whenever
you
> > > want to, that's all that is needed.  No hotplug stuff, no filename
> > > stuff, just a simple copy.
> > Greg, all the feedback gave the impression that request_firmwae
hotplug
> > stuff was the way to go.
> 
> It is the way to go.
> 
> > Seems it's not required!
> 
> Not at all, why do you think I mean that?
I meant this driver does not need hotplug per say and just a copy should
be enough (if we decide to go with bin attribute for data file).
> 
> > Now that means it needs to be done the way it was before except that
> > it needs to have a bin attribute for data and a normal attribute for
> > size.  This would be even better as it makes it easy to read back
the
> > data.
> 
> No, you can still use the firmware core code, that's what it is there
> for.  But don't mess with the "make the user provide a filename"
stuff.
> Just have your driver create the firmware request and then relax.
Your
> code will get called when the firware is written to, right?  That's
all
> you need.
> 
At what point I should be calling request_firmware? As my driver does
not have any entry points. In this driver it is called when the user is
ready to download the firmware image (when it echoes the firmware image
name). Also the driver needs to be resident for handling multiple such
requests; that's why cannot do this at driver init time.
When ever the user echoes the file name, it gets passed on to
request_firmware and the $FIRMWARE env gets populated with the file
name. thus making the hotplug code to automatically load the image which
is passed back as fw->data and fw->size. 
> What's with this obsession about firmware filenames... :)
> 
The file name can be same (hardcode) for every update; but writing the
file name was a way to get the user start the update process.

Thanks
Abhay
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/