On Wed, 1 Jun 2005, Prarit Bhargava wrote:
> Prarit Bhargava wrote:
> > Greg KH wrote:
> >
> >> [PATCH] PCI Hotplug: more CPCI updates
> >
> >
> >> - Switch to pci_get_slot instead of deprecated pci_find_slot.
> >> - A bunch of CodingStyle fixes.
> >
> >
> >> - }
> >> + dev = pci_get_slot(slot->bus, PCI_DEVFN(slot->number, 0));
> >> + if (dev) {
> >> + if (update_adapter_status(slot->hotplug_slot, 1))
> >> + warn("failure to update adapter file");
> >> + if (update_latch_status(slot->hotplug_slot, 1))
> >> + warn("failure to update latch file");
> >> + slot->dev = dev;
> >> }
> >> }
> >
> >
> > I don't claim to know the code as well as Scott or Greg does, but I
> > don't see a pci_put_dev for the slot->dev to clean up the usage count?
>
> s/pci_put_dev/pci_dev_put/g
Sorry Prarit, when you suggested I switch over to pci_get_slot in your
previous comments to me, I didn't look that closely and missed the
reference counting. Greg, I think the required fix is just a couple of
lines in my hotplug slot release function, I'll code it up and test it
ASAP tomorrow with an eye on getting a patch off by early afternoon EDT.
Scott
--
Scott Murray
SOMA Networks, Inc.
Toronto, Ontario
e-mail: [email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
