Hi,
On Wed, 2005-06-01 at 07:50 +0800, Benjamin Herrenschmidt wrote:
> On Wed, 2005-06-01 at 00:45 +1000, Benjamin Herrenschmidt wrote:
> > On Tue, 2005-05-31 at 12:36 +0200, Pavel Machek wrote:
> > > Hi!
> > >
> > > > If we specify a swap device for swsusp using resume= kernel
> argument and
> > > > that device doesn't exist in the swap list, we end up calling
> > > > swsusp_free() before we have allocated pagedir_save. That causes
> us to
> > > > explode when trying to free it.
> > > >
> > > > Pavel, does that look right ?
> > >
> > > It looks like a workaround. We should not call swsusp_free in
> case
> > > device does not exists. Quick look did not reveal where the bug
> comes
> > > from, can you try to trace it?
> > > Pavel
> >
> > Well, the bug comes from arch code calling swsusp_save() which
> fails,
> > then we call swsusp_free()
>
> More specifically, arch suspend calls swsusp_save().
>
> It fails and returns the error to the arch asm code, which itself
> returns it to it's caller swsusp_suspend(), which does that:
>
> if ((error = swsusp_arch_suspend()))
> swsusp_free();
I encounter a similar issue, when swsusp_swap_check failed.
It seems the swsusp_free isn't required in the failure case,
suspend_prepare_image has correctly handled the failure case to me.
Other arch? I wonder why swsusp_free is called after device_power_down
failed as well. No pages are allocated before device_power_down.
Thanks,
Shaohua
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
