Re: [PATCH 1/2] Introduce tty_unregister_ldisc()

On Tue, May 31, 2005 at 05:28:11PM -0500, Paul Fulghum wrote:
> This patch is wrong. Please do not apply.
> 
> An unmodified ldisc driver (externally maintained) will continue to call
> tty_register_ldisc with NULL, but the new behavior will be to set the
> ldisc pointer to NULL but have LDISC_FLAG_DEFINED set.

Then fix that code.  We can not do anything about externally maintained
code, sorry.  

> If you feel it is absolutely necessary to add this new function
> for cosmetic reasons, then leave the old behavior in place
> and make tty_unregister_ldisc a wrapper to tty_register_ldisc
> that uses a NULL pointer.
> 
> This preserves sanity and compatibility.

We don't care about compatibility in order to keep our sanity.  See
Documentation/stable_api_nonsense.txt for details :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/2] Introduce tty_unregister_ldisc()
    • From: Alexey Dobriyan <[email protected]>
  • Re: [PATCH 1/2] Introduce tty_unregister_ldisc()
    • From: Paul Fulghum <[email protected]>

• Prev by Date: Re: Human tIming perception (was: RT patch)
• Next by Date: [PATCH] PCI Hotplug: SHPCHP driver doesn't enable PERR and SERR properly
• Previous by thread: Re: [PATCH 1/2] Introduce tty_unregister_ldisc()
• Next by thread: Re: [PATCH 1/2] Introduce tty_unregister_ldisc()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]