sparsemem-memory-model.patch references SECTIONS_SHIFT without defining it. Caught this while compiling with -Wundef, causes lots of warnings when it gets used in include/linux/mm.h. The appended patch Works For Me, although I wonder if the *real* problem isn't a missing '#ifdef CONFIG_SPARSEMEM' around the code that uses it in mm.h. Signed-Off-By: [email protected] --- linux-2.6.12-rc5-mm1/include/linux/mmzone.h.ifdef 2005-05-27 15:12:26.000000000 -0400 +++ linux-2.6.12-rc5-mm1/include/linux/mmzone.h 2005-05-27 16:26:40.000000000 -0400 @@ -568,6 +568,7 @@ static inline int pfn_valid(unsigned lon void sparse_init(void); #else #define sparse_init() do {} while (0) +#define SECTIONS_SHIFT 0 #endif /* CONFIG_SPARSEMEM */ #ifdef CONFIG_NODES_SPAN_OTHER_NODES
Attachment:
pgpC0VYCGBVYz.pgp
Description: PGP signature
- Follow-Ups:
- Re: 2.6.12-rc5-mm1 - missing #define SECTIONS_SHIFT in sparsemem
- From: Andy Whitcroft <[email protected]>
- Re: 2.6.12-rc5-mm1 - missing #define SECTIONS_SHIFT in sparsemem
- From: Andy Whitcroft <[email protected]>
- Re: 2.6.12-rc5-mm1 - missing #define SECTIONS_SHIFT in sparsemem
- Prev by Date: Re: RT and Cascade interrupts
- Next by Date: [patch 2.6.12-rc5] pcmcia/cs.c and SS_CAP_STATIC_MAP
- Previous by thread: [PATCH] DRM depends on ???
- Next by thread: Re: 2.6.12-rc5-mm1 - missing #define SECTIONS_SHIFT in sparsemem
- Index(es):
 |