Francois Romieu wrote:
Jeff Garzik <[email protected]> :
[tulip_media_select]
1) called from timer context, from the media poll timer
2) called from spin_lock_irqsave() context, in the ->tx_timeout hook.
The first case can be fixed by moved all the timer code to a workqueue.
Then when the existing timer fires, kick the workqueue.
The second case can be fixed by kicking the workqueue upon tx_timeout
(which is the reason why I did not suggest queue_delayed_work() use).
First try below. It only moves tulip_select_media() to process context.
The original patch (with s/udelay/msleep/ or such) is not included.
Patch applies/compiles against 2.6.12-rc4.
Looks pretty good to me, at first look.
I'll give it some thought, and probably apply it, in a few days.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
