On Sun, May 22, 2005 at 09:05:07PM +0100, Mel Gorman wrote:
> /*
> + * Calculate the size of the zone->usemap
> + */
> +static unsigned long __init usemap_size(unsigned long zonesize) {
> + unsigned long usemapsize;
> +
> + /* - Number of MAX_ORDER blocks in the zone */
> + usemapsize = (zonesize + (1 << (MAX_ORDER-1))) >> (MAX_ORDER-1);
> +
> + /* - BITS_PER_ALLOC_TYPE bits to record what type of block it is */
> + usemapsize = (usemapsize * BITS_PER_ALLOC_TYPE + (sizeof(unsigned long)*8)) / 8;
> +
> + return L1_CACHE_ALIGN(usemapsize);
> +}
In the first calculation, I think you are trying to 'round up'. If this
is the case, then I believe the calculation should be:
usemapsize = (zonesize + ((1 << (MAX_ORDER-1)) - 1) >> (MAX_ORDER-1);
I don't know if there is a similar issue in the second calculation.
Arithmetic is not one of my strengths.
--
Mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
