Dcookies shouldn't play with the internals of dentry and vfsmnt
refcounting. It defeats grepping, and is prone to break if
implementation details change.
In addition the function doesn't even seem to be performance critical:
it calls kmem_cache_alloc().
Signed-off-by: Miklos Szeredi <[email protected]>
Index: linux/fs/dcookies.c
===================================================================
--- linux.orig/fs/dcookies.c 2004-12-24 22:33:48.000000000 +0100
+++ linux/fs/dcookies.c 2005-05-25 17:14:08.000000000 +0200
@@ -94,12 +94,10 @@ static struct dcookie_struct * alloc_dco
if (!dcs)
return NULL;
- atomic_inc(&dentry->d_count);
- atomic_inc(&vfsmnt->mnt_count);
dentry->d_cookie = dcs;
- dcs->dentry = dentry;
- dcs->vfsmnt = vfsmnt;
+ dcs->dentry = dget(dentry);
+ dcs->vfsmnt = mntget(vfsmnt);
hash_dcookie(dcs);
return dcs;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
